Add full montage-data repo to montage/data/ directory#1847
Merged
Conversation
The bug would present itself when the converter was used by a pipeline converter and a foreign descriptor was not supplied.
DataService#createdDataObjects is a property not a function.
Move AuthorizationPolicy out of DataService and into it’s own module. This removes the need for AuthorizationManager to depend on DataService and returns the dependency tree back to it’s pre-Auth API state.
Streamline logic in expression-data-mapping, raw-data-service, and raw-property-to-value-converter to remove the need to check whether a given property will return a promise or not. All properties that return object descriptors now return promises. Update DataMapping API signature to return promises for mapRawDataToObject & mapObjectToRawData.
…hanges in deserialization
Contributor
Author
|
Lint and merge master into features/data branch
…sion-data-mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate montage-twitter sample app has reference: